Repository navigation
Fix aquarium in Firefox. Only enable multiview when VR is supported - #45
Merged
Merged
Conversation
Member
|
Thanks for this fix Brian. It looks good to me but Brandon, could you double-check? |
Contributor
|
LGTM as well, thanks! It's unfortunate that Firefox is reporting |
Contributor
Author
|
Thanks for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aquarium sample is currently broken in Firefox on Ubuntu using Nvidia drivers with the following error.
Apparently Firefox thinks OVR_multiview2 is available to use on Ubuntu since
gl.getExtension('OVR_multiview2')returns with an extension object.This PR changes the sample code to use multiview only if VR support is detected. Tested with Firefox and Chrome on Ubuntu, Windows, Vive Browser on Vive XR Elite, and Cardboard. Would appreciate help testing on a Quest device.