Repository navigation
Conversation
Add configuration for the Gemini Code Assist GitHub app to experiment with automatic code reviews. The hope is that this will especially help with initial feedback for PRs from new contributors. Also add code review instructions in .gemini/styleguide.md. These instructions are derived from our code review history and will help guide the reviews from GCA.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| * Reuse existing helpers in `src/ir/` (`Properties`, `Bits`, `ChildLocalizer`, | ||
| `ModuleUtils`, `TableUtils`, `MemoryUtils`, `LUBFinder`, | ||
| `SubtypingDiscoverer`, `Match` in `src/ir/match.h`) instead of duplicating | ||
| logic. |
There was a problem hiding this comment.
There is a lot of detail here. Do we need it? Maybe we can try without it and add as we go? Or did you derive this list that way somehow?
There was a problem hiding this comment.
I told Gemini something like "use gh to get our entire review history and come up with a guide based on that." I have no idea how effective any particular part of the guide is, or what the optimal level of detail is. Since this isn't meant for human consumption, I'm not too concerned about having this be a large grab bag of information.
Starting with no guidance here and then trying to add it back in if we think the reviews aren't very useful sounds like a reasonable strategy. Alternatively, we could err on the side of providing more information to try to get the most useful reviews out of the gate; I doubt removing information would make the reviews better.
Happy to go with whatever your preference is.
There was a problem hiding this comment.
I've removed it for now.
|
lgtm if it works! |
Add configuration for the Gemini Code Assist GitHub app to experiment with automatic code reviews. The hope is that this will especially help with initial feedback for PRs from new contributors. Also add code review instructions in .gemini/styleguide.md. These instructions are derived from our code review history and will help guide the reviews from GCA.