Repository navigation
Conversation
When a non-escaping allocation flows into the `expected` operand of a `struct.atomic.rmw.cmpxchg` or `array.atomic.rmw.cmpxchg`, `Struct2Local` rewrites the cmpxchg into a block ending with a `struct.atomic.get` or `array.atomic.get` on a scratch local holding `curr->ref`. When `curr->ref` has a null reference type, the original cmpxchg takes its result type from `curr->replacement`, whereas the replacement `struct.get` or `array.get` refines its result type to `(ref none)`. Refinalize to propagate the refined type when this happens.
tlively
requested review from
stevenfontanella
and removed request for
a team
October 16, 2026 19:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a non-escaping allocation flows into the
expectedoperand of astruct.atomic.rmw.cmpxchgorarray.atomic.rmw.cmpxchg,Struct2Localrewrites the cmpxchg into a block ending with astruct.atomic.getorarray.atomic.geton a scratch local holdingcurr->ref. Whencurr->refhas a null reference type, the original cmpxchg takes its result type fromcurr->replacement, whereas the replacementstruct.getorarray.getrefines its result type to(ref none). Refinalize to propagate the refined type when this happens.