Expose try_table and throw_ref in C and JS API - #9057
Open
ospencer wants to merge 1 commit into
Open
Conversation
chharvey
approved these changes
Aug 28, 2026
kripken
reviewed
Aug 28, 2026
| assert(expression->is<TryTable>()); | ||
| assert(index < static_cast<TryTable*>(expression)->catchTags.size()); | ||
| static_cast<TryTable*>(expression)->catchTags[index] = | ||
| catchTag ? Name(catchTag) : Name(); |
Member
There was a problem hiding this comment.
@aheejin do we need to call refinalize() here so that sentTypes is repopulated?
ospencer
force-pushed
the
oscar/expose-new-exceptions
branch
from
August 29, 2026 05:04
b15fd5c to
b0d708b
Compare
Contributor
Author
|
Realized I had the ordering wrong everywhere; should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding these because I really want to use them. Let me know if there was a reason why these weren't there (I figure no one needed it yet).