Heap2Local: fix stale data cmpxchg bug#8856
Closed
tlively wants to merge 1 commit into
Closed
Conversation
Fix a misoptimization bug where stale `analyzer.parents` and local graph data caused the ref.eq generated during the optimization of struct.atomic.rmw.cmpxchg to not be optimized. This led to a situation where the ref.eq would incorrectly evaluate to true when a null struct field value and a separate optimized allocations flowed into it. Fix the problem by better tracking the new local sets and gets and parent relationships added during optimization. Keeping this information more up-to-date allows the escape analysis for subsequent allocations to find the fix the new ref.eq. Fixes #8850.
Member
|
I would prefer your #8857 to this, unless we have a strong reason against that PR? |
Member
Author
|
Nope, that sounds fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a misoptimization bug where stale
analyzer.parentsand local graph data caused the ref.eq generated during the optimization of struct.atomic.rmw.cmpxchg to not be optimized. This led to a situation where the ref.eq would incorrectly evaluate to true when a null struct field value and a separate optimized allocations flowed into it.Fix the problem by better tracking the new local sets and gets and parent relationships added during optimization. Keeping this information more up-to-date allows the escape analysis for subsequent allocations to find the fix the new ref.eq.
Fixes #8850.