Skip d8 lit tests on windows - #8788
Merged
Merged
Conversation
Member
|
It seems to pass sometimes if that means anything? I hit this error in a PR and was able to re-run it successfully. |
Member
Author
|
Interesting, I haven't seen it pass recently. All the last few commits on main error this way, so I think we need to skip these. |
stevenfontanella
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not clear why v8 is not installed on CI specifically on windows-arm,
but apparently it isn't. As this just affects 4 tests, skip them on windows.
Example error:
https://github.com/WebAssembly/binaryen/actions/runs/26543251282/job/78189409612