MergeBlocks: Migrate from invalidates to orderedBefore - #8767
Merged
Conversation
Replace the coarse 'invalidates' check in 'MergeBlocks' with 'orderedBefore'. This allows 'MergeBlocks' to move expressions (like GC reads) out of blocks past other sibling expressions that have been left behind. Also clean up dead code in 'optimize()' by removing the unused 'dependency1' and 'dependency2' parameters and their checks (which were the other two replaced 'invalidates' calls that are no longer active). TAG=agy
aheejin
approved these changes
May 24, 2026
Comment on lines
+15
to
+17
| ;; Test 1: Disallowed reordering (GC read NOT moved before Wasm acquire load) | ||
| ;; Child 0 is named, so it is NOT optimized and its effects (acquire load) are left behind. | ||
| ;; Child 1 tries to move the GC read out, which should be blocked because it cannot move before the acquire load. |
Member
There was a problem hiding this comment.
NIt: Comment 80-col wrapping. The same for Test 2
tlively
enabled auto-merge (squash)
May 26, 2026 15:43
tlively
disabled auto-merge
May 26, 2026 15:48
Member
|
@tlively The new lit test here is failing on e.g. https://github.com/WebAssembly/binaryen/actions/runs/26468274003/job/77934377247 |
Member
Author
|
Yep, my bad. I'll have a fix up in a few. The test output just needs to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the coarse 'invalidates' check in 'MergeBlocks' with 'orderedBefore'. This allows 'MergeBlocks' to move expressions (like GC reads) out of blocks past other sibling expressions that have been left behind.
Also clean up dead code in 'optimize()' by removing the unused 'dependency1' and 'dependency2' parameters and their checks (which were the other two replaced 'invalidates' calls that are no longer active).
TAG=agy