Skip to content

[WIP] Improve effects analysis for indirect calls #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevenfontanella wants to merge 11 commits into from
+489 −109
Closed

[WIP] Improve effects analysis for indirect calls #8583

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ca88c5b
Add tests for indirect calls
stevenfontanella Apr 6, 2026
513362c
Start changing
stevenfontanella Apr 6, 2026
7fd7418
Done but not working
stevenfontanella Apr 7, 2026
2fbd478
Working in closed world test
stevenfontanella Apr 7, 2026
225564f
Work on subtyping
stevenfontanella Apr 7, 2026
17f779f
Try adding subtyping, not working
stevenfontanella Apr 7, 2026
e0d287f
Done??
stevenfontanella Apr 8, 2026
3311a77
Start cleaning up
stevenfontanella Apr 8, 2026
89fa118
more cleanup
stevenfontanella Apr 8, 2026
8f03f50
Account for functions that don't have their address taken
stevenfontanella Apr 8, 2026
4cbc6b2
More tests
stevenfontanella Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More tests
  • Loading branch information
@stevenfontanella
stevenfontanella committed Apr 8, 2026
commit 4cbc6b25e30aa0af6e4e75fc09f218810e814c00
51 changes: 43 additions & 8 deletions test/lit/passes/global-effects-closed-world.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
;; CHECK: (type $maybe-has-effects (func (param i32 i32)))
(type $maybe-has-effects (func (param i32 i32)))

;; CHECK: (type $only-has-effects-in-non-exported-function (func (param f32 f32)))

;; CHECK: (type $nopType (func (param i32)))
(type $nopType (func (param i32)))

Expand All @@ -25,6 +27,8 @@
;; CHECK: (type $func-with-super-param (sub $func-with-sub-param (func (param (ref $super)))))
(type $func-with-super-param (sub $func-with-sub-param (func (param (ref $super)))))

(type $only-has-effects-in-non-exported-function (func (param f32 f32)))

(table 10 funcref)

;; CHECK: (global $g (mut i32) (i32.const 0))
Expand All @@ -51,7 +55,7 @@
(nop)
)

;; CHECK: (func $calls-nop-via-ref (type $6) (param $ref (ref $nopType))
;; CHECK: (func $calls-nop-via-ref (type $7) (param $ref (ref $nopType))
;; CHECK-NEXT: (call_ref $nopType
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (local.get $ref)
Expand All @@ -65,7 +69,7 @@
(call_ref $nopType (i32.const 1) (local.get $ref))
)

;; CHECK: (func $f (type $6) (param $ref (ref $nopType))
;; CHECK: (func $f (type $7) (param $ref (ref $nopType))
;; CHECK-NEXT: (nop)
;; CHECK-NEXT: )
(func $f (param $ref (ref $nopType))
Expand All @@ -74,7 +78,7 @@
(call $calls-nop-via-ref (local.get $ref))
)

;; CHECK: (func $calls-effectful-function-via-ref (type $7) (param $ref (ref $maybe-has-effects))
;; CHECK: (func $calls-effectful-function-via-ref (type $8) (param $ref (ref $maybe-has-effects))
;; CHECK-NEXT: (call_ref $maybe-has-effects
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (i32.const 2)
Expand All @@ -85,7 +89,7 @@
(call_ref $maybe-has-effects (i32.const 1) (i32.const 2) (local.get $ref))
)

;; CHECK: (func $g (type $7) (param $ref (ref $maybe-has-effects))
;; CHECK: (func $g (type $8) (param $ref (ref $maybe-has-effects))
;; CHECK-NEXT: (call $calls-effectful-function-via-ref
;; CHECK-NEXT: (local.get $ref)
;; CHECK-NEXT: )
Expand All @@ -96,7 +100,7 @@
(call $calls-effectful-function-via-ref (local.get $ref))
)

;; CHECK: (func $calls-uninhabited (type $8) (param $ref (ref $uninhabited))
;; CHECK: (func $calls-uninhabited (type $9) (param $ref (ref $uninhabited))
;; CHECK-NEXT: (call_ref $uninhabited
;; CHECK-NEXT: (f32.const 0)
;; CHECK-NEXT: (local.get $ref)
Expand All @@ -106,7 +110,7 @@
(call_ref $uninhabited (f32.const 0) (local.get $ref))
)

;; CHECK: (func $h (type $8) (param $ref (ref $uninhabited))
;; CHECK: (func $h (type $9) (param $ref (ref $uninhabited))
;; CHECK-NEXT: (nop)
;; CHECK-NEXT: )
(func $h (param $ref (ref $uninhabited))
Expand All @@ -129,7 +133,7 @@
(unreachable)
)

;; CHECK: (func $calls-ref-with-subtype (type $9) (param $func (ref $func-with-sub-param)) (param $sub (ref $sub))
;; CHECK: (func $calls-ref-with-subtype (type $10) (param $func (ref $func-with-sub-param)) (param $sub (ref $sub))
;; CHECK-NEXT: (call_ref $func-with-sub-param
;; CHECK-NEXT: (local.get $sub)
;; CHECK-NEXT: (local.get $func)
Expand All @@ -139,7 +143,7 @@
(call_ref $func-with-sub-param (local.get $sub) (local.get $func))
)

;; CHECK: (func $asdf (type $9) (param $func (ref $func-with-sub-param)) (param $sub (ref $sub))
;; CHECK: (func $asdf (type $10) (param $func (ref $func-with-sub-param)) (param $sub (ref $sub))
;; CHECK-NEXT: (call $calls-ref-with-subtype
;; CHECK-NEXT: (local.get $func)
;; CHECK-NEXT: (local.get $sub)
Expand All @@ -154,4 +158,35 @@
;; include the unreachable effect and we can't optimize out this call.
(call $calls-ref-with-subtype (local.get $func) (local.get $sub))
)

;; CHECK: (func $no-effects (type $only-has-effects-in-non-exported-function) (param $0 f32) (param $1 f32)
;; CHECK-NEXT: (nop)
;; CHECK-NEXT: )
(func $no-effects (type $only-has-effects-in-non-exported-function) (param f32 f32)
)

;; CHECK: (func $has-effects-but-not-exported (type $only-has-effects-in-non-exported-function) (param $0 f32) (param $1 f32)
;; CHECK-NEXT: (unreachable)
;; CHECK-NEXT: )
(func $has-effects-but-not-exported (type $only-has-effects-in-non-exported-function) (param f32 f32)
(unreachable)
)

;; CHECK: (func $calls-type-with-effects-but-not-addressable (type $11) (param $ref (ref $only-has-effects-in-non-exported-function))
;; CHECK-NEXT: (call_ref $only-has-effects-in-non-exported-function
;; CHECK-NEXT: (f32.const 0)
;; CHECK-NEXT: (f32.const 0)
;; CHECK-NEXT: (local.get $ref)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $calls-type-with-effects-but-not-addressable (param $ref (ref $only-has-effects-in-non-exported-function))
(call_ref $only-has-effects-in-non-exported-function (f32.const 0) (f32.const 0) (local.get $ref))
)

;; CHECK: (func $i (type $11) (param $ref (ref $only-has-effects-in-non-exported-function))
;; CHECK-NEXT: (nop)
;; CHECK-NEXT: )
(func $i (param $ref (ref $only-has-effects-in-non-exported-function))
(call $calls-type-with-effects-but-not-addressable (local.get $ref))
)
)
Loading