Skip to content

Allow JS and C to read the start function of a module #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 6 commits into from
Apr 2, 2025
Merged

Allow JS and C to read the start function of a module #7424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af2b751
Add BinaryenGetStart function
GulgDev Apr 1, 2025
27dda73
Add setStart function to JS wrapper
GulgDev Apr 1, 2025
c592649
Merge pull request #1 from GulgDev/patch-2
GulgDev Apr 1, 2025
1735b91
Add BinaryenGetStart test
GulgDev Apr 2, 2025
f8914f3
Add module.getStart test
GulgDev Apr 2, 2025
a8d5841
Add BinaryenGetStart function declaration
GulgDev Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/binaryen-c.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5289,6 +5289,10 @@ void BinaryenSetStart(BinaryenModuleRef module, BinaryenFunctionRef start) {
((Module*)module)->addStart(((Function*)start)->name);
}

BinaryenFunctionRef BinaryenGetStart(BinaryenModuleRef module) {
return ((Module*)module)->getFunctionOrNull(((Module*)module)->start);
}

// Features

BinaryenFeatures BinaryenModuleGetFeatures(BinaryenModuleRef module) {
Expand Down
2 changes: 2 additions & 0 deletions src/binaryen-c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2869,6 +2869,8 @@ BINARYEN_API void BinaryenAddDataSegment(BinaryenModuleRef module,
BINARYEN_API void BinaryenSetStart(BinaryenModuleRef module,
BinaryenFunctionRef start);

BINARYEN_API BinaryenFunctionRef BinaryenGetStart(BinaryenModuleRef module);

// Features

// These control what features are allowed when validation and in passes.
Expand Down
3 changes: 3 additions & 0 deletions src/js/binaryen.js-post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2594,6 +2594,9 @@ function wrapModule(module, self = {}) {
self['setStart'] = function(start) {
return Module['_BinaryenSetStart'](module, start);
};
self['getStart'] = function() {
return Module['_BinaryenGetStart'](module);
};
self['getFeatures'] = function() {
return Module['_BinaryenModuleGetFeatures'](module);
};
Expand Down
1 change: 1 addition & 0 deletions test/binaryen.js/kitchen-sink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ function test_core() {
// Start function. One per module
var starter = module.addFunction("starter", binaryen.none, binaryen.none, [], module.nop());
module.setStart(starter);
assert(module.getStart() == starter);

var features = binaryen.Features.All;
module.setFeatures(features);
Expand Down
1 change: 1 addition & 0 deletions test/example/c-api-kitchen-sink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,6 +1376,7 @@ void test_core() {
0,
BinaryenNop(module));
BinaryenSetStart(module, starter);
assert(BinaryenGetStart(module) == starter);

BinaryenFeatures features = BinaryenFeatureAll();
BinaryenModuleSetFeatures(module, features);
Expand Down
Loading