[C/JS API] Add string reference types#4810
Merged
Merged
Conversation
dcodeIO
commented
Jul 21, 2022
| BinaryenTypeExpand(stringref, &valueType); | ||
| assert(valueType == stringref); | ||
|
|
||
| BinaryenType stringview_wtf8_ = BinaryenTypeStringviewWtf8(); |
Contributor
Author
There was a problem hiding this comment.
Note: The _ is there to substitute ref so these don't conflict with the heap types of the same name that another PR adds tests for below.
kripken
reviewed
Jul 26, 2022
kripken
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
stringref,stringview_wtf8,stringview_wtf16andstringview_iterreference types to the C and JS APIs.