Remove redundant allocator in Builder#3144
Merged
tlively merged 1 commit intoSep 22, 2020
Merged
Conversation
Builders gained a `Module` field in WebAssembly#3130 because they now require extra context to properly finalize some Expressions. Since modules contain allocators, the old allocator field on the builder became redundant after that change. This PR removes the redundant allocator field.
aardappel
approved these changes
Sep 21, 2020
aardappel
left a comment
Contributor
There was a problem hiding this comment.
Cool.. I was tempted to make it this way, but didn't know if it would have any side effects.
| asmFunc[3]->push_back(processFunction(wasm, func)); | ||
| }); | ||
| if (generateFetchHighBits) { | ||
| Builder builder(allocator, *wasm); |
Contributor
There was a problem hiding this comment.
is this separate allocator still used?
Member
Author
There was a problem hiding this comment.
Nope, removed it everywhere now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builders gained a
Modulefield in #3130 because they now require extra contextto properly finalize some Expressions. Since modules contain allocators, the old
allocator field on the builder became redundant after that change. This PR
removes the redundant allocator field.