Skip to content

Code pushing support for br_on_exn#2660

Merged
aheejin merged 2 commits into
WebAssembly:masterfrom
aheejin:eh_code_pushing
Feb 19, 2020
Merged

Code pushing support for br_on_exn#2660
aheejin merged 2 commits into
WebAssembly:masterfrom
aheejin:eh_code_pushing

Conversation

@aheejin

@aheejin aheejin commented Feb 18, 2020

Copy link
Copy Markdown
Member

Like br_if, br_on_exn is a conditional branch and across which code
can be pushed past when conditions are satisfied.

Also adds a few lines of comments and NFC changes in a couple places.
Changes in Vacuum are NFC because they were being handled in default:
in the same way anyway, but I added them to be more explicit and
consistent with existing code.

Like `br_if`, `br_on_exn` is a conditional branch and across which code
can be pushed past when conditions are satisfied.
@aheejin aheejin requested a review from kripken February 18, 2020 19:20

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aheejin aheejin merged commit eca1a66 into WebAssembly:master Feb 19, 2020
@aheejin aheejin deleted the eh_code_pushing branch February 19, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants