Cleanup travis configuration#2641
Merged
Merged
Conversation
a9875e8 to
111c299
Compare
- explicitly name each job so its clear in the UI. - split flake8 and other linkers into thier own job rather than doing these things N times. - rename the `build` phase to `archive` since build could mean any number of things (normally it means that thing you do before testing not after). - combine the gcc test with the out-of-tree test
111c299 to
21fba39
Compare
Member
|
Is it worth cleaning up given #2646? |
Member
Author
|
Yeah, cleaning this up is incremental and is helpful for the transition (IMHO). |
kripken
approved these changes
Feb 7, 2020
| - mkdir -p ${BUILD_SUBDIR} && cd ${BUILD_SUBDIR} | ||
| - cmake ${TRAVIS_BUILD_DIR} -DCMAKE_C_FLAGS="$COMPILER_FLAGS" -DCMAKE_CXX_FLAGS="$COMPILER_FLAGS" -DCMAKE_EXE_LINKER_FLAGS="$LINKER_FLAGS" -DCMAKE_INSTALL_PREFIX=install -DCMAKE_EXPORT_COMPILE_COMMANDS=ON | ||
| # clang-tidy-diff.sh may not exist when BUILD_SUBDIR is a subdirectory | ||
| - if [ -f clang-tidy-diff.sh ]; then ./clang-tidy-diff.sh; fi |
Member
There was a problem hiding this comment.
is this if and the comment explaining it no longer relevant? cc @aheejin
Member
Author
There was a problem hiding this comment.
Yeah.. the problem was the cd above which is no longer part of the lint phase. So is not long needed or relevant. Much cleaner this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildphase toarchivesince build could mean anynumber of things (normally it means that thing you do before testing
not after).