Allow all features on wasm2js and add atomic tests#2311
Merged
Conversation
This adds `-all` argument to wasm2js testing and fixes wasm2js to actually take that argument (currently it doesn't, when it takes a wast file). This also adds a wasm2js test for `atomic.fence` instruction that was added in WebAssembly#2307.
Member
Author
|
The wasm2js change feels a bit hacky and I'm not sure if it's the right direction... Please let me know if there's a better way. |
aheejin
commented
Aug 27, 2019
| private: | ||
| Options() = delete; | ||
| Options(const Options&) = delete; | ||
| Options& operator=(const Options&) = delete; |
Member
Author
There was a problem hiding this comment.
These prevent Options and its subclasses from being passed as function arguments. Not sure why they were added, but deleted them to pass OptimizationOptions as by argument.
aheejin
commented
Aug 27, 2019
| Output& out, | ||
| Wasm2JSBuilder::Flags flags, | ||
| PassOptions options) | ||
| const OptimizationOptions& options) |
Member
Author
There was a problem hiding this comment.
This is to use applyFeatures within the class
tlively
reviewed
Aug 27, 2019
kripken
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
-allargument to wasm2js testing and fixes wasm2js toactually take that argument (currently it doesn't, when it takes a wast
file). This also adds a wasm2js test for
atomic.fenceinstruction thatwas added in #2307.