Allow running a portion of binaryen test suite#2286
Merged
Conversation
Member
|
Can you add some usage examples in a comment at the top of check.py? |
sbc100
approved these changes
Aug 6, 2019
sbc100
left a comment
Member
There was a problem hiding this comment.
I have a very similar change I've been working on. I like your version better though.
Could we do that same for auto_update_tests.py perhaps in a followup?
Member
How about having a proper help message about the usage for |
jgravelle-google
left a comment
Contributor
There was a problem hiding this comment.
Great change! +1 for some light documentation.
tlively
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.