Loosen conditions on MemoryPacking#2205
Merged
Merged
Conversation
Allow MemoryPacking to run when there are no passive segments, even if bulk memory is enabled.
kripken
approved these changes
Jul 2, 2019
kripken
left a comment
Member
There was a problem hiding this comment.
About the test - is bulk memory on by default? I'm not sure why the old test had it disabled. I thought no features were on by default?
| // Conservatively refuse to change segments if bulk memory is enabled to | ||
| // avoid invalidating segment indices or segment contents referenced from | ||
| if (!module->memory.exists) | ||
| return; |
Member
There was a problem hiding this comment.
{ } if not on the same line.
@aheejin didn't we have clang-tidy check for that?
Member
There was a problem hiding this comment.
We do. Travis CI is pending now, but once it runs it will error out.
Member
There was a problem hiding this comment.
Thanks, and sorry I didn't notice it was still pending.
Member
Author
|
The test must have been a holdover from when all features were enabled by default. I guess we should go through and make sure there aren't any others. |
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow MemoryPacking to run when there are no passive segments, even if
bulk memory is enabled.
Fixes #2196.