Skip to content

Wasm2js memory fixes#2003

Merged
kripken merged 13 commits into
masterfrom
wasm2js
Apr 12, 2019
Merged

Wasm2js memory fixes#2003
kripken merged 13 commits into
masterfrom
wasm2js

Conversation

@kripken

@kripken kripken commented Apr 12, 2019

Copy link
Copy Markdown
Member
  • I64ToI32Lowering - don't assume address 0 is a hardcoded location for scratch memory. Import __tempMemory__ for that.
  • RemoveNonJSOps - also use __tempMemory__. Oddly here the address was a hardcoded 1024 (perhaps where the rust program put a static global?).
  • Support imported ints in wasm2js, coercing them as needed.
  • Add "env" import support in the tests, since now we emit imports from there.
  • Make wasm2js tests split out multi-module tests using split_wast which is more robust and avoids emitting multiple outputs in one file (which makes no sense for ES6 modules)

@kripken kripken merged commit 883d14d into master Apr 12, 2019
@kripken kripken deleted the wasm2js branch April 12, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant