Skip to content

Add scope_extensions member to manifest incubations spec#113

Merged
LuHuangMSFT merged 21 commits intogh-pagesfrom
luhua-scope-extensions-spec
May 30, 2025
Merged

Add scope_extensions member to manifest incubations spec#113
LuHuangMSFT merged 21 commits intogh-pagesfrom
luhua-scope-extensions-spec

Conversation

@LuHuangMSFT
Copy link
Copy Markdown
Collaborator

@LuHuangMSFT LuHuangMSFT commented Apr 6, 2025

Add scope_extensions member to manifest incubations spec

Spec implementation of the scope_extension explainer.


Preview | Diff

@LuHuangMSFT LuHuangMSFT self-assigned this Apr 6, 2025
@LuHuangMSFT LuHuangMSFT added the scope-extensions https://github.com/WICG/manifest-incubations/blob/gh-pages/scope_extensions-explainer.md label Apr 9, 2025
@LuHuangMSFT
Copy link
Copy Markdown
Collaborator Author

LuHuangMSFT commented Apr 9, 2025

@diekus @HowardWolosky PTAL.

@LuHuangMSFT LuHuangMSFT requested a review from dmurph April 9, 2025 18:44
@LuHuangMSFT
Copy link
Copy Markdown
Collaborator Author

LuHuangMSFT commented Apr 11, 2025

Working on an update to this PR to define "extended scope" as a new concept as a union of "scope" as defined in the original W3C spec AND new scope extensions. This way we can avoid overriding definitions in the original spec (monkey-patching problem).

Copy link
Copy Markdown
Collaborator

@dmurph dmurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
LuHuangMSFT and others added 4 commits April 25, 2025 14:59
Co-authored-by: Daniel Murphy <dmurph@chromium.org>
Co-authored-by: Daniel Murphy <dmurph@chromium.org>
@LuHuangMSFT LuHuangMSFT requested a review from dmurph April 30, 2025 19:07
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html
@LuHuangMSFT LuHuangMSFT requested a review from dmurph May 29, 2025 01:03
@LuHuangMSFT
Copy link
Copy Markdown
Collaborator Author

PTA(another)L. Comments addressed. Thanks!

@LuHuangMSFT LuHuangMSFT merged commit edc0979 into gh-pages May 30, 2025
1 check passed
@LuHuangMSFT LuHuangMSFT deleted the luhua-scope-extensions-spec branch May 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope-extensions https://github.com/WICG/manifest-incubations/blob/gh-pages/scope_extensions-explainer.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants