Skip to content

Add named-capturing group#70

Merged
lanwen merged 5 commits into
VerbalExpressions:masterfrom
zawataki:master
Oct 11, 2018
Merged

Add named-capturing group#70
lanwen merged 5 commits into
VerbalExpressions:masterfrom
zawataki:master

Conversation

@zawataki
Copy link
Copy Markdown
Contributor

@zawataki zawataki commented Oct 11, 2018

Fixed #67

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 99.379% when pulling edb2a18 on tkzwyk:master into b11ef5d on VerbalExpressions:master.

@zawataki
Copy link
Copy Markdown
Contributor Author

zawataki commented Oct 11, 2018 •
edited
Loading

Hi @lanwen , do you know why coverage decreasing?

#69 also decreased just by modifying a comment.

@lanwen
Copy link
Copy Markdown
Contributor

lanwen commented Oct 11, 2018

Seems that it was not collected at all for some reason

@zawataki
Copy link
Copy Markdown
Contributor Author

zawataki commented Oct 11, 2018

Hi @lanwen , thank you for reply. I updated coveralls-maven-plugin version to 4.3.0 (latest), so the coverage increased.
Could you please review this pr?

lanwen
lanwen reviewed Oct 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@lanwen lanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just some minors.

Also please add usage example somewhere (can be javadoc)

Comment thread src/test/java/ru/lanwen/verbalregex/RealWorldUnitTest.java Outdated
Comment thread src/test/java/ru/lanwen/verbalregex/RealWorldUnitTest.java Outdated
Comment thread src/test/java/ru/lanwen/verbalregex/BasicFunctionalityUnitTest.java
@lanwen lanwen merged commit 4ee34e6 into VerbalExpressions:master Oct 11, 2018
@zawataki
Copy link
Copy Markdown
Contributor Author

zawataki commented Oct 11, 2018

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lanwen lanwen lanwen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zawataki @coveralls @lanwen