Report the failed training status for failed Model Target downloads - #3443
Merged
Conversation
A download request for a Model Target dataset which is not ready always reported ``not-started`` as the training status, including for a dataset whose generation failed. Report ``failed`` for those, and document that the name real Vuforia uses for a failed dataset has not been observed. Partial progress on #3195. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GET /modeltargets/{datasets,advancedDatasets}/{uuid}/datasetfor a dataset which is not ready returns a422 UNSUPPORTED_STATEerror whose message names the dataset's training status. The mock hardcodednot-started, so a dataset whose generation failed — which has finished processing — was reported as not having started.The mock now reports
failedfor those, and keepsnot-startedfor the whole processing window, which is what real Vuforia returns for a dataset requested just after creation (observed in #3203).Why
Partial progress on #3195 (make Model Target dataset downloads more realistic). The failed-download path had no test at all.
Notes
TestMockOnlyErrors, anddocs/source/differences-to-vws.rstrecords the assumption.🤖 Generated with Claude Code