Pin the coverage version used by the coverage gate - #3422
Merged
Conversation
The "Combine & check coverage" job installed coverage with "uv tool install", which resolves the latest release at run time and ignores the project's pin of coverage==7.15.4. It was the only unpinned tool install across the workflows, and it is a required check on the default branch, so its behaviour was decided by whatever coverage released most recently. Run it through "uv run --extra=dev" like every other tool invocation, so the same version produces and consumes the coverage data. Also add "|| true" to the first report call. Under "bash -e" it already failed the step when coverage was under 100%, so the second call - the one the comment says is the gate - was unreachable in exactly the case it exists for. Closes #3402 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Combine & check coveragejob installedcoveragewithuv tool install, which resolves the latest release at run time and ignores the project's pin ofcoverage==7.15.4. It was the only unpinned tool install across the workflows, and it is a required check on the default branch, so its behaviour was decided by whatevercoveragereleased most recently — and the job producing the coverage data used a different (pinned) version from the job consuming it.Run it through
uv run --extra=dev, like every other tool invocation in the workflows.Also add
|| trueto the firstcoverage reportcall. Underbash -ethat call already failed the step when coverage was under 100%, so the second call — the one the comment says is the gate — was unreachable in exactly the case it exists for.Closes #3402
🤖 Generated with Claude Code