Map the ProjectHasNoApiAccess result code - #3145
Merged
Merged
Conversation
Vuforia's result codes table spells this ``ProjectHasNoApiAccess``, while this package mapped only ``ProjectHasNoAPIAccess``, a spelling which came from a hand-written list in ``vws-python-mock`` rather than an observed response. No real response with either casing has been found, so both casings now map to ``ProjectHasNoAPIAccessError`` and the ambiguity is recorded in the code. ``vws-python-mock`` 2026.8.14 changes the mock to the documented spelling, so the pin is bumped to it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Vuforia does not document the ProjectHasNoAPIAccess casing, so drop it from the result code map rather than keeping it as an alias. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit deeb0ff. Configure here.
| "ProjectHasNoAPIAccess": ProjectHasNoAPIAccessError, | ||
| # This casing comes from Vuforia's result codes table. No real | ||
| # response with this result code has been observed, with this or any | ||
| # other casing. |
There was a problem hiding this comment.
Dropped result-code mapping raises KeyError
Medium Severity
Removing the ProjectHasNoAPIAccess mapping means VWSError.from_result_code raises KeyError for a result code this package previously turned into ProjectHasNoAPIAccessError. The PR keeps that spelling mapped because no live Vuforia body has been seen, so either casing can still arrive.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit deeb0ff. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3128.
Vuforia's result codes table spells this result code
ProjectHasNoApiAccess, while this package mapped onlyProjectHasNoAPIAccess— a spelling which traces back to a hand-written list invws-python-mockrather than an observed response. No real response with this result code has been found, with either casing.ProjectHasNoApiAccessnow maps toProjectHasNoAPIAccessError.ProjectHasNoAPIAccess, which Vuforia does not document, is no longer mapped.vws-python-mockpin is bumped to2026.8.14, the release which contains the mock-side casing change (Match the result codes table casing for ProjectHasNoApiAccess vws-python-mock#3352), so the mock-backed project-state test exercises the documented spelling.The exception class name is unchanged.
🤖 Generated with Claude Code
Note
Low Risk
Small registry-key change in exception mapping; only callers depending on the undocumented
ProjectHasNoAPIAccessstring would see different behavior.Overview
Aligns VWS result-code handling with Vuforia’s documented spelling
ProjectHasNoApiAccess(lowercase “pi” in “Api”).VWSError.from_result_codenow maps that string to the existingProjectHasNoAPIAccessError; the previously mappedProjectHasNoAPIAccesskey is removed because it is not in Vuforia’s table.The exception class name is unchanged; only the docstring and registry key reflect the documented code. A unit test asserts the documented casing maps correctly, and the
vws-python-mockdev dependency is bumped so mock-backed project-state tests use the same spelling.Reviewed by Cursor Bugbot for commit 9eb5e1c. Bugbot is set up for automated code reviews on this repo. Configure here.