Skip to content

Change m g d to 'Go to declaration' for Python major mode - #411

Open
niontrix wants to merge 1 commit into
VSpaceCode:masterfrom
niontrix:patch-2
Open

Change m g d to 'Go to declaration' for Python major mode#411
niontrix wants to merge 1 commit into
VSpaceCode:masterfrom
niontrix:patch-2

Conversation

@niontrix

@niontrix niontrix commented Jun 12, 2026

Copy link
Copy Markdown

m g d is a duplication of m g g in Python major mode, so I fixed that.

KR

`m g d` is a duplication of `m g g` in Python major mode, so fixed that.
@marcoieni

Copy link
Copy Markdown
Member

What I wrote in #410 (comment) is still valid 👍

@niontrix

Copy link
Copy Markdown
Author

Maybe :) but it wasn't my intention to change m g g. I just wanted to fix the duplication. Can you merge my PR, please?

@niontrix

Copy link
Copy Markdown
Author

@marcoieni can you please merge my PR or do you want to retain the duplication? (which would not make sense in my mind)

@marcoieni

Copy link
Copy Markdown
Member

I don't want to merge this pr because of my comment in the other pr. If another maintainer wants to review this and merge, I'm fine with it

@niontrix

niontrix commented Jul 4, 2026

Copy link
Copy Markdown
Author

In cpp major mode bindings there already is precedent that m g d is used for "Go to declaration". So why keep the duplication for Python? Yes, you are right in so far that this should be changed for all major modes in consequence so the user has a uniform experience. And if it's required I'll gladly make a PR for the rest of them. But why would it make sense to keep a duplication that serves no useful function instead of providing another useful keybinding?
Also, in spacemacs m g g is generally used for "Go to definition" so I would not change that.

@marcoieni

Copy link
Copy Markdown
Member

I don't have the capacity of reading your response and dealing with this PR, sorry

@niontrix

niontrix commented Jul 4, 2026

Copy link
Copy Markdown
Author

@vic, @joefiorini, @mvzink could any of you please take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants