Repository navigation
Conversation
Contributor
Author
|
Validation for exact head
This is a source-safety verdict. The performance and document-parity measurements in the description precede the cleanup repair; they do not establish an ENG-1425 timeout fix. The PR remains draft pending the broader investigation; no merge or deployment. authored by codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached split-PDF responses currently buffer the complete HTTP body before writing it to disk. This change streams cached responses to disk as they arrive, reducing memory use when several chunks finish together.
Body reads, cache writes and HTTP response cleanup remain inside the semaphore and retry boundary. Cancellation waits for owned I/O to finish. The response wrapper retains its transport iterator and joins one close task, so cleanup stays inside admission even when iteration stops after a failed write. Failed attempts remove incomplete files; only complete responses receive a cache path. The noncached response path is unchanged.
Observed results
This is a measured memory improvement for concurrent cached responses.
authored by codex