Skip to content

chore: replace DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG#4006

Open
NoelStephensUnity wants to merge 1 commit into
develop-2.0.0from
chore/replace-development-build
Open

chore: replace DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG#4006
NoelStephensUnity wants to merge 1 commit into
develop-2.0.0from
chore/replace-development-build

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

Purpose of this PR

Working progress (still running various tests)

  • Replacing DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG.
  • Replacing niche DEVELOPMENT_BUILD uses with DEBUG.

Jira ticket

WIP

Changelog

  • Changed: Replacing define usages of DEVELOPMENT_BUILD || UNITY_EDITOR and a few niche uses of DEVELOPMENT_BUILD with DEBUG.

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done
    • Test project link pending

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port is required since this applies to 6000.6+.

Replacing DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG.
Replacing niche DEVELOPMENT_BUILD uses with DEBUG.
Copy link
Copy Markdown
Member

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some files in there that look like accidental adds (PerformanceTestRunInfo, SceneTransitioningBase1). But otherwise this looks like a change we should have done ages ago! Massively simplifies some of those checks!

@@ -0,0 +1 @@
{"TestSuite":"","Date":0,"Player":{"Development":false,"ScreenWidth":0,"ScreenHeight":0,"ScreenRefreshRate":0,"Fullscreen":false,"Vsync":0,"AntiAliasing":0,"Batchmode":false,"RenderThreadingMode":"Split","MtRendering":false,"GraphicsJobs":false,"GpuSkinning":true,"Platform":"","ColorSpace":"","AnisotropicFiltering":"","BlendWeights":"","GraphicsApi":"","ScriptingBackend":"Mono2x","AndroidTargetSdkVersion":"AndroidApiLevelAuto","AndroidBuildSystem":"Gradle","BuildTarget":"StandaloneWindows64","StereoRenderingPath":"MultiPass"},"Hardware":{"OperatingSystem":"","DeviceModel":"","DeviceName":"","ProcessorType":"","ProcessorCount":0,"GraphicsDeviceName":"","SystemMemorySizeMB":0},"Editor":{"Version":"6000.4.0f1","Branch":"6000.4/staging","Changeset":"8cf496087c8f","Date":1773430047},"Dependencies":["com.unity.addressables@2.9.1","com.unity.ai.navigation@2.0.11","com.unity.collab-proxy@2.11.4","com.unity.ide.rider@3.0.39","com.unity.ide.visualstudio@2.0.27","com.unity.mathematics@1.3.3","com.unity.multiplayer.tools@2.2.8","com.unity.netcode.gameobjects@2.13.0","com.unity.package-validation-suite@0.49.0-preview","com.unity.services.authentication@3.6.0","com.unity.services.multiplayer@2.1.3","com.unity.test-framework@1.6.0","com.unity.test-framework.performance@3.2.0","com.unity.timeline@1.8.11","com.unity.ugui@2.0.0","com.unity.modules.accessibility@1.0.0","com.unity.modules.adaptiveperformance@1.0.0","com.unity.modules.ai@1.0.0","com.unity.modules.androidjni@1.0.0","com.unity.modules.animation@1.0.0","com.unity.modules.assetbundle@1.0.0","com.unity.modules.audio@1.0.0","com.unity.modules.cloth@1.0.0","com.unity.modules.director@1.0.0","com.unity.modules.imageconversion@1.0.0","com.unity.modules.imgui@1.0.0","com.unity.modules.jsonserialize@1.0.0","com.unity.modules.particlesystem@1.0.0","com.unity.modules.physics@1.0.0","com.unity.modules.physics2d@1.0.0","com.unity.modules.screencapture@1.0.0","com.unity.modules.terrain@1.0.0","com.unity.modules.terrainphysics@1.0.0","com.unity.modules.tilemap@1.0.0","com.unity.modules.ui@1.0.0","com.unity.modules.uielements@1.0.0","com.unity.modules.umbra@1.0.0","com.unity.modules.unityanalytics@1.0.0","com.unity.modules.unitywebrequest@1.0.0","com.unity.modules.unitywebrequestassetbundle@1.0.0","com.unity.modules.unitywebrequestaudio@1.0.0","com.unity.modules.unitywebrequesttexture@1.0.0","com.unity.modules.unitywebrequestwww@1.0.0","com.unity.modules.vectorgraphics@1.0.0","com.unity.modules.vehicles@1.0.0","com.unity.modules.video@1.0.0","com.unity.modules.vr@1.0.0","com.unity.modules.wind@1.0.0","com.unity.modules.xr@1.0.0","com.unity.modules.subsystems@1.0.0","com.unity.modules.hierarchycore@1.0.0","com.unity.ext.nunit@2.0.5","com.unity.transport@2.6.0","com.unity.collections@6.4.0","com.unity.services.qos@1.4.1","com.unity.services.core@1.16.0","com.unity.services.wire@1.4.2","com.unity.services.deployment@1.7.2","com.unity.nuget.newtonsoft-json@3.2.2","com.unity.nuget.mono-cecil@1.11.6","com.unity.burst@1.8.28","com.unity.profiling.core@1.0.3","com.unity.scriptablebuildpipeline@2.6.1","com.unity.services.deployment.api@1.1.3"],"Results":[]} No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be added?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, looks accidental

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants