Skip to content

fix: Various bugs causing rust test failures on trunk#3941

Open
EmandM wants to merge 5 commits intodevelop-2.0.0from
fix/rust-tests
Open

fix: Various bugs causing rust test failures on trunk#3941
EmandM wants to merge 5 commits intodevelop-2.0.0from
fix/rust-tests

Conversation

@EmandM
Copy link
Copy Markdown
Member

@EmandM EmandM commented Apr 14, 2026

Purpose of this PR

Various overlapping fixes that'll fix the rust tests on trunk.

Jira ticket

UUM-131552

Changelog

  • Fixed: CreateObject and DestroyObject messages will now be properly deferred while the client is still connecting
  • Fixed: Resources will be properly cleaned up when an object spawn fails

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

n/a

@EmandM EmandM marked this pull request as ready for review April 15, 2026 14:21
@EmandM EmandM requested review from a team and NoelStephensUnity as code owners April 15, 2026 14:21
@EmandM EmandM changed the title Fix: Various bugs causing rust test failures on trunk fix: Various bugs causing rust test failures on trunk Apr 15, 2026
@michalChrobot
Copy link
Copy Markdown
Member

Just to clarify, changes related to the ticket from PR description caused that somehow?

Copy link
Copy Markdown
Member

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just had to manually trigger trunk job (LINK) so we make sure it works

As far as I remember at some point we switched trunk testing for 6000.5 for more stability (see https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/blob/fix/rust-tests/.yamato/_triggers.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants