Skip to content

Support startColumn field in the SARIF report #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmvpm merged 5 commits into from
Jul 8, 2022
Merged

Support startColumn field in the SARIF report #454

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0afba1
Support startColumn field in the SARIF report (#452)
mmvpm Jul 7, 2022
ff2d2d1
Add unit tests (#452)
mmvpm Jul 7, 2022
1741b70
Fix after review (#452)
mmvpm Jul 8, 2022
aeabf14
Add comment (#452)
mmvpm Jul 8, 2022
7d02c28
Rollback coverage usage (#452)
mmvpm Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests (#452)
  • Loading branch information
@mmvpm
mmvpm committed Jul 8, 2022
commit ff2d2d12994603444446d7de3dc4dea33d13fa3a
5 changes: 4 additions & 1 deletion utbot-framework/src/test/kotlin/org/utbot/sarif/SarifReportTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ class SarifReportTest {
assert(location.region.startLine == 1337)
assert(relatedLocation.artifactLocation.uri.contains("MainTest.java"))
assert(relatedLocation.region.startLine == 1)
assert(relatedLocation.region.startColumn == 1)
}

@Test
Expand Down Expand Up @@ -158,6 +159,7 @@ class SarifReportTest {
}
assert(codeFlowPhysicalLocations[0].artifactLocation.uri.contains("MainTest.java"))
assert(codeFlowPhysicalLocations[0].region.startLine == 3)
assert(codeFlowPhysicalLocations[0].region.startColumn == 7)
}

@Test
Expand All @@ -181,6 +183,7 @@ class SarifReportTest {
}
assert(codeFlowPhysicalLocations[0].artifactLocation.uri.contains("MainTest.java"))
assert(codeFlowPhysicalLocations[0].region.startLine == 4)
assert(codeFlowPhysicalLocations[0].region.startColumn == 5)
}

// internal
Expand Down Expand Up @@ -217,7 +220,7 @@ class SarifReportTest {
private val generatedTestsCodeMain = """
public void testMain_ThrowArithmeticException() {
Main main = new Main();
main.main(0);
main.main(0); // shift for `startColumn` == 7
}
""".trimIndent()

Expand Down