Skip to content

Disabled NPE checks for non-public library fields by default #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Damtev merged 8 commits into from
Jul 7, 2022
Merged

Disabled NPE checks for non-public library fields by default #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7cf9b50
Disabled NPE checks for non-public fields in non-application classes …
Damtev Jun 27, 2022
62df0e4
Added test
Damtev Jun 29, 2022
3308cf1
Fixed rebasing error
Damtev Jun 29, 2022
603aff9
Added docs
Damtev Jun 30, 2022
0644c98
Enabled reflection for ContestEstimator
Damtev Jun 30, 2022
4526d3b
Fixed review issues
Damtev Jun 30, 2022
98c2dda
Added trusted libraries scope
Damtev Jul 4, 2022
be48844
Used only JDK as a default trusted library
Damtev Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed review issues
  • Loading branch information
@Damtev
Damtev committed Jul 7, 2022
commit 4526d3ba3f97d239dcd8195e8e66978753f4bf67
2 changes: 1 addition & 1 deletion docs/SpeculativeFieldNonNullability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ most of generated branches would be `NPE` branches, while useful paths could be
Beyond that, in many cases the `null` value of a field can't be generated using the public API
of the class. This is particularly true for final fields, especially in system classes.
it is also often true for non-public fields from standard library and third-party libraries (even setters often do not
allow `null` values). Automatically generated tests assign `null` values to fields in questions using reflection,
allow `null` values). Automatically generated tests assign `null` values to fields using reflection,
but these tests may be uninformative as the corresponding `NPE` branches would never occur
in the real code that limits itself to the public API.

Expand Down
2 changes: 1 addition & 1 deletion utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ object UtSettings {
var checkNpeInNestedNotPrivateMethods by getBooleanProperty(false)

/**
* This option determines whether should we generate [NullPointerException] checks for final or non-public fields
* This option determines whether we should generate [NullPointerException] checks for final or non-public fields
* in non-application classes. Set by true, this option highly decreases test's readability in some cases
* because of using reflection API for setting final/non-public fields in non-application classes.
*
Expand Down