Update PR template with requirements for labels and titles#1714
Merged
Conversation
alisevych
reviewed
Jan 19, 2023
|
|
||
| Check off the item if the statement is true: | ||
|
|
||
| - [ ] I've set the proper **labels** for my PR. |
Member
There was a problem hiding this comment.
I would add here:
(at least, category and component)
alisevych
reviewed
Jan 19, 2023
Member
alisevych
left a comment
There was a problem hiding this comment.
Looks very good to me. Only minor corrections suggested.
|
|
||
| - [ ] I've set the proper **labels** for my PR. | ||
| - [ ] PR **title** and **description** are clear and intelligible. | ||
| - [ ] I've added enough **comments** to help people understand my code. |
Member
There was a problem hiding this comment.
I would suggest to leave "particularly in hard-to-understand areas" - seems that we try to avoid unnecessary commenting.
alisevych
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, it took a lot of time to classify PRs based on the type of change and the related component. To streamline release process, reviewing and contributing, we introduce the PR template with the requirements for using labels and giving titles, and the new self-check list.
How to test
Manual tests
The PR introduces no code changes.
Manual scenario: the text itself has been previewed in the IntelliJ IDEA viewer.
Self-check list