Skip to content

Publish plugin and CLI for minor release #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viktoriia-fomina merged 4 commits into from
Oct 14, 2022
Merged

Publish plugin and CLI for minor release #1155

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4ea2e3
Add minor release versions
viktoriia-fomina Oct 14, 2022
79663b2
Fix minor version
viktoriia-fomina Oct 14, 2022
563939a
Fix minor release indicators
viktoriia-fomina Oct 14, 2022
2614ee8
Fix a bug with none
viktoriia-fomina Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix a bug with none
  • Loading branch information
@viktoriia-fomina
viktoriia-fomina authored Oct 14, 2022
commit 2614ee8bdad046dfa831d11ca940a5730ae5277d
2 changes: 1 addition & 1 deletion .github/workflows/publish-plugin-and-cli-from-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
type: choice
description: "It adds minor release indicator to version."
required: true
default: ''
default: 'none'
options:
Copy link
Copy Markdown
Member

@bissquit bissquit Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we choose between these values only?

Copy link
Copy Markdown
Member Author

@viktoriia-fomina viktoriia-fomina Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we choose between these values only?

I don't think it's possible to have more than 4 minor releases in a month. I don't want to give the possibility to publish occasionally an artifact with the wrong version

- 'none'
- '1'
Expand Down