Skip to content

Fix contour level color mapping with explicit limits #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 12 commits into from
Feb 26, 2026
Merged

Fix contour level color mapping with explicit limits #599

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6c87a64
Fix contour level color mapping with explicit limits
cvanelteren Feb 26, 2026
47f070f
Update ultraplot/axes/plot.py
cvanelteren Feb 26, 2026
bdbc5ff
Merge branch 'main' into fix/issue-329-contour-color-mapping
cvanelteren Feb 26, 2026
bf1dd57
Fix `_parse_level_norm` docstring to reflect conditional return type …
Copilot Feb 26, 2026
bddbcd6
Merge branch 'main' into fix/issue-329-contour-color-mapping
cvanelteren Feb 26, 2026
21195ec
Scope explicit contour limits to line contours
cvanelteren Feb 26, 2026
e7b881a
Pass vmin/vmax through automatic level generation
cvanelteren Feb 26, 2026
e5c3116
Restore default tricontour discrete mapping
cvanelteren Feb 26, 2026
940ac89
Format contour norm routing changes
cvanelteren Feb 26, 2026
574bcd0
Clarify contour norm routing docs
cvanelteren Feb 26, 2026
fd44af3
Refactor contour norm routing flow
cvanelteren Feb 26, 2026
0008b82
Refactor contour norm routing flags
cvanelteren Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format contour norm routing changes
  • Loading branch information
@cvanelteren
cvanelteren committed Feb 26, 2026
commit 940ac89f649fe0470355b1142db2be6f2ab03963
4 changes: 3 additions & 1 deletion ultraplot/axes/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4837,7 +4837,9 @@ def _parse_level_norm(
# with explicit limits or qualitative color lists, keep the continuous
# normalizer to preserve one-to-one value->color mapping.
center_levels = _not_none(center_levels, rc["colorbar.center_levels"])
Comment on lines +4846 to 4849
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _parse_level_norm docstring says it returns a DiscreteNorm/BoundaryNorm, but with the new min_levels == 1 behavior it can return the original continuous Normalize (line contours). Please update the Returns section to reflect the possible return types so users don't rely on an incorrect contract.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@cvanelteren cvanelteren Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

preserve_line_mapping = preserve_line_limits or (min_levels == 1 and qualitative)
preserve_line_mapping = preserve_line_limits or (
min_levels == 1 and qualitative
)
if (
not preserve_line_mapping
and not isinstance(norm, mcolors.BoundaryNorm)
Expand Down