fix: make workspace attachment linking idempotent - #160
Open
andreitava-uip wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes workspace attachment linking idempotent during dehydration by querying existing job attachment associations once and skipping already-linked attachments, preventing duplicate association errors—especially across resume scenarios in a new hydrator process.
Changes:
- Link attachments in one deterministic pass after dehydration, skipping already-associated attachments.
- Add a regression test covering dehydration after resume with an already-linked attachment.
- Bump the package version to
0.13.2(and lockfile update).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/uipath/runtime/workspace/hydrator.py |
Centralizes attachment linking into an idempotent batch flow by listing current associations once and linking only missing keys. |
tests/workspace/test_workspace_hydration.py |
Extends the fake jobs API to track existing associations and adds a regression test ensuring resumed dehydration doesn’t re-link. |
pyproject.toml |
Bumps project version to 0.13.2. |
uv.lock |
Updates lockfile metadata to reflect version 0.13.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing