rearrange spans for eval trace#1757
Closed
PopescuTudor wants to merge 1 commit into
Closed
Conversation
radu-mocanu
requested changes
Jun 24, 2026
radu-mocanu
left a comment
Collaborator
There was a problem hiding this comment.
Golden-rule review. Produced by a UiPath Coded Agent, itself built with the UiPath Python SDK, the code that lives in this very repository.
1 golden-rule violation(s) found:
src/uipath/_cli/_evals/_runtime.py:305: Confirm a version bump accompanies this logic change- This change alters runtime behavior by adding new tracing spans and an exporter option, which is a logic change. I cannot see a package version bump in the diff. If one is not present, please bump the version so this change does not ride an unrelated version.
- Fix: Confirm the package version is bumped in the appropriate project file as part of this change.
| ) | ||
| # Create the parent "Evaluation set run" span | ||
| tracer = trace.get_tracer(__name__) | ||
| span_attributes = { |
Collaborator
There was a problem hiding this comment.
Confirm a version bump accompanies this logic change
This change alters runtime behavior by adding new tracing spans and an exporter option, which is a logic change. I cannot see a package version bump in the diff. If one is not present, please bump the version so this change does not ride an unrelated version.
Fix: Confirm the package version is bumped in the appropriate project file as part of this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--