Fix destructuring assignment of multiReturn (closes #995) - #997
Merged
Conversation
Perryvw
reviewed
Mar 5, 2021
Perryvw
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, looks good! I only have some minor comments.
Perryvw
reviewed
Mar 6, 2021
| export {a, b}; | ||
| ` | ||
| .setOptions(multiProjectOptions) | ||
| .expectToEqual({ b: [] }); |
Member
There was a problem hiding this comment.
Could you also check the value of a here? (should be undefined)
| ` | ||
| .setOptions(multiProjectOptions) | ||
| .expectToEqual({ a: 1, b: [2, 3] }); | ||
| util.testModule` |
Member
There was a problem hiding this comment.
Tests should only test one thing, could you split this second testModule into a second test("Destructuring assignment of LuaMultiReturn returning nil", () => {
Perryvw
approved these changes
Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue. Turns out we were dealing with this problem on normal assignments, so something like this works:
This is handled here: https://github.com/TypeScriptToLua/TypeScriptToLua/blob/master/src/transformation/visitors/binary-expression/assignments.ts#L94-L97
Maybe this is an indicative that this needs some refactoring, as that code should be common. However, I just fixed the issue locally, and added a test showing it is now working.
The only other change is a snapshot of a test that's supposed to fail, so that shouldn't be a problem I believe.
npm testworks.