Skip to content

Fixed issue in test code formatting, fixed array.splice and array.join - #734

Merged
Perryvw merged 5 commits into
masterfrom
feature/splice-fix
Oct 9, 2019
Merged

Fixed issue in test code formatting, fixed array.splice and array.join#734
Perryvw merged 5 commits into
masterfrom
feature/splice-fix

Conversation

@Perryvw

@Perryvw Perryvw commented Oct 6, 2019

Copy link
Copy Markdown
Member

Makes #733 obsolete.

  • Merged test util.valueToString and util.valuesToString into single util.formatCode
  • Fixed issue in case array.join was called with undefined argument.
  • Fixed inconsistency between lua and js with regards to array.splice arguments.

@Perryvw
Perryvw requested a review from ark120202 October 8, 2019 20:10
ark120202
ark120202 reviewed Oct 8, 2019
View reviewed changes
Comment thread src/LuaTransformer.ts Outdated
Comment thread src/lualib/ArraySplice.ts
@Perryvw
Perryvw requested a review from ark120202 October 9, 2019 19:40
@Perryvw
Perryvw merged commit b7e7296 into master Oct 9, 2019
@Perryvw
Perryvw deleted the feature/splice-fix branch October 9, 2019 19:47
@Perryvw Perryvw mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ark120202 ark120202 ark120202 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Perryvw @ark120202