Transformation Pipeline Refactor - #705
Merged
Perryvw merged 44 commits intoDec 7, 2019
Merged
Conversation
Perryvw
reviewed
Aug 21, 2019
Perryvw
reviewed
Aug 21, 2019
Perryvw
reviewed
Aug 21, 2019
| return exportSpecifiers.map(exportSpecifier => transformExportSpecifier(context, exportSpecifier)); | ||
| } | ||
|
|
||
| // export { ... } from "..."; |
Member
There was a problem hiding this comment.
I like this coding style from this file, as a general reminder also to myself, maybe we should add this to some style guide.
Perryvw
reviewed
Oct 29, 2019
Perryvw
reviewed
Oct 31, 2019
ark120202
force-pushed
the
transformation-pipeline-refactor
branch
from
November 3, 2019 03:25
ca718f4 to
0c18503
Compare
Perryvw
reviewed
Nov 3, 2019
| const expression = ts.isExpressionStatement(node) ? node.expression : node; | ||
| if (ts.isDeleteExpression(expression)) { | ||
| return lua.createAssignmentStatement( | ||
| cast(context.transformExpression(expression.expression), lua.isAssignmentLeftHandSideExpression), |
Member
There was a problem hiding this comment.
How about renaming cast to verifyType?
Contributor
Author
There was a problem hiding this comment.
For me, verify implies that it's returning an error on failure, not throwing.
Maybe something like assertWith(value, cast) (which is just assert(cast(value)), but with a better failure message)? We'd have to upgrade TS to 3.7 for that though
Merged
ark120202
force-pushed
the
transformation-pipeline-refactor
branch
from
November 24, 2019 00:54
01cbec6 to
6a3af12
Compare
Perryvw
reviewed
Nov 30, 2019
ark120202
marked this pull request as ready for review
December 7, 2019 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #615, closes #559.