Simplify and improve enum transform - #685
Merged
Perryvw merged 5 commits intoAug 3, 2019
Merged
Conversation
ark120202
force-pushed
the
simplify-and-improve-enum-transform
branch
from
August 1, 2019 06:41
740f7bf to
91313ae
Compare
ark120202
marked this pull request as ready for review
August 1, 2019 06:42
Perryvw
reviewed
Aug 1, 2019
| } else { | ||
| valueExpression = tstl.createNumericLiteral(numericValue); | ||
| numericValue++; | ||
| valueExpression = tstl.createNilLiteral(); |
Member
There was a problem hiding this comment.
Looking at this again, is this actually correct? In what case would an enum value be nil?
Contributor
Author
There was a problem hiding this comment.
Original transformer has the same branch: https://github.com/microsoft/TypeScript/blob/master/src/compiler/transformers/ts.ts#L2442.
I have thought it'd be used for some syntactically incorrect enums, but couldn't find any cases where TS goes there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #683, fixes #684.
Fixes string literal references:
Tests depend on #609.