typeof improvements - #625
Merged
Merged
Conversation
Perryvw
reviewed
Jun 6, 2019
| const code = ` | ||
| let val = ${expression}; | ||
| if (typeof val ${operator} "${compareTo}") { | ||
| return "TRUE"; |
Member
There was a problem hiding this comment.
This looks a little odd, any reason you don't just return typeof val ${operator} "${compareTo}"?
Perryvw
reviewed
Jun 6, 2019
Perryvw
reviewed
Jun 6, 2019
| case ts.SyntaxKind.SlashToken: | ||
| case ts.SyntaxKind.PercentToken: | ||
| case ts.SyntaxKind.PercentToken: { | ||
| const lhs = this.transformExpression(expression.left); |
Member
There was a problem hiding this comment.
Any reason we calculate these in here at all, instead of inside transformBinaryOperation? Seems like a historic thing that's probably not relevant anymore?
Collaborator
Author
There was a problem hiding this comment.
transformBinaryOperation expects already transformed expressions, because it is sometimes given manually constructed ones (like from compound assignments)
Perryvw
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #613
fixes #612
typeof is now transpiled into a lib function, except in cases where it is directly compared to a string literal, in which case lua's
type()is used and the literal is changed (if needed).