Skip to content

Added array.reduce #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 7 commits into from
May 27, 2019
Merged

Added array.reduce #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc6bbae
Added array.reduce
Perryvw May 26, 2019
41a1ef3
Removed unused import
Perryvw May 26, 2019
289a24e
Update src/lualib/ArrayReduce.ts
Perryvw May 26, 2019
278e72d
Fixed error test
Perryvw May 26, 2019
cb1e2c0
Merge branch 'master' into feature/reduce
Perryvw May 27, 2019
e84966e
Updated tests
Perryvw May 27, 2019
a85d9a0
Added undefined deleteCount test
Perryvw May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/LuaLib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export enum LuaLibFeature {
ArrayIndexOf = "ArrayIndexOf",
ArrayMap = "ArrayMap",
ArrayPush = "ArrayPush",
ArrayReduce = "ArrayReduce",
ArrayReverse = "ArrayReverse",
ArrayShift = "ArrayShift",
ArrayUnshift = "ArrayUnshift",
Expand Down
2 changes: 2 additions & 0 deletions src/LuaTransformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4404,6 +4404,8 @@ export class LuaTransformer {
return this.transformLuaLibFunction(LuaLibFeature.ArrayMap, node, caller, ...params);
case "filter":
return this.transformLuaLibFunction(LuaLibFeature.ArrayFilter, node, caller, ...params);
case "reduce":
return this.transformLuaLibFunction(LuaLibFeature.ArrayReduce, node, caller, ...params);
case "some":
return this.transformLuaLibFunction(LuaLibFeature.ArraySome, node, caller, ...params);
case "every":
Expand Down
28 changes: 28 additions & 0 deletions src/lualib/ArrayReduce.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// https://www.ecma-international.org/ecma-262/9.0/index.html#sec-array.prototype.reduce
function __TS__ArrayReduce<T>(
this: void,
arr: T[],
callbackFn: (accumulator: T, currentValue: T, index: number, array: T[]) => T,
initial?: T
): T {
const len = arr.length;

if (len === 0 && initial === undefined) {
// tslint:disable-next-line: no-string-throw
throw "Reduce of empty array with no initial value";
}

let k = 0;
let accumulator = initial;
if (initial === undefined) {
accumulator = arr[0];
k++;
}

while (k < len) {
accumulator = callbackFn(accumulator, arr[k], k, arr);
k = k + 1;
}

return accumulator;
}
10 changes: 6 additions & 4 deletions src/lualib/ArraySlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
// https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf 22.1.3.23
// https://www.ecma-international.org/ecma-262/9.0/index.html#sec-array.prototype.slice
function __TS__ArraySlice<T>(this: void, list: T[], first: number, last: number): T[] {
const len = list.length;

const relativeStart = first || 0;

let k: number;
if (first < 0) {
k = Math.max(len + first, 0);
if (relativeStart < 0) {
k = Math.max(len + relativeStart, 0);
} else {
k = Math.min(first, len);
k = Math.min(relativeStart, len);
}

let relativeEnd = last;
Expand Down
Loading