Added support for importequals declaration - #598
Merged
Conversation
Member
Author
|
I feel like there has to be a better way to do transformers.ts:503, but I don't know how. |
ark120202
reviewed
May 26, 2019
ark120202
left a comment
Contributor
There was a problem hiding this comment.
It also probably should have special handling for require call, like type checker does, or we should disallow all module targets except es6 and esnext
| } | ||
|
|
||
| public transformQualifiedName(qualifiedName: ts.QualifiedName): ExpressionVisitResult { | ||
| const right = this.transformIdentifier(qualifiedName.right); |
Contributor
There was a problem hiding this comment.
Suggested change
| const right = this.transformIdentifier(qualifiedName.right); | |
| const right = this.transformIdentifierExpression(qualifiedName.right); |
Right now there's no much difference, but still it should make more sense and also be consistent with regular variable declaration.
| public transformEntityName(entityName: ts.EntityName): ExpressionVisitResult { | ||
| return ts.isQualifiedName(entityName) | ||
| ? this.transformQualifiedName(entityName) | ||
| : this.transformIdentifier(entityName); |
Contributor
There was a problem hiding this comment.
Suggested change
| : this.transformIdentifier(entityName); | |
| : this.transformIdentifierExpression(entityName); |
Contributor
|
Since imports are transformed into regular vars they are also supposed to be hoisted |
tomblind
reviewed
May 26, 2019
| public transformExternalModuleReference( | ||
| externalModuleReference: ts.ExternalModuleReference | ||
| ): ExpressionVisitResult { | ||
| return this.transformExpression(externalModuleReference.expression); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be wrapped in a require? Right now,
import foo = require("./bar");transpiles to:
local foo = "./bar"
tomblind
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #587