Feature/api interface - #561
Merged
Merged
Conversation
lolleko
approved these changes
May 4, 2019
| public transformSetAccessorDeclaration( | ||
| setAccessor: ts.SetAccessorDeclaration, | ||
| className: tstl.Identifier, | ||
| classDeclaration: ts.ClassLikeDeclaration |
Member
There was a problem hiding this comment.
Are you sure you want to remove the declaration parameter? I think there could be use cases were you would want to access it.
Or is it possible to access the ClassDeclaration via the SetAccessorDeclaration ?
Member
Author
There was a problem hiding this comment.
setAccessor.parent should be the class declaration. I would also prefer to remove the className actually, but I'm not sure yet how exactly.
| } | ||
|
|
||
| private joinChunks(separator: string, chunks: SourceChunk[]): SourceChunk[] { | ||
| protected isEmptyStatement(statement: tstl.Statement): boolean { |
Member
There was a problem hiding this comment.
Should probably name that isStatementEmpty
tomblind
approved these changes
May 4, 2019
# Conflicts: # src/LuaTransformer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up visitorPattern interface in printer and transformer.