Class decorators - #558
Merged
Merged
Conversation
Contributor
Author
|
Resolves #537 |
Perryvw
requested changes
May 3, 2019
ark120202
reviewed
May 4, 2019
ark120202
left a comment
Contributor
There was a problem hiding this comment.
Also, it would be nice to have an error when decorators are used in not yet supported locations
Perryvw
reviewed
May 4, 2019
…tToLua into class_decorators
Perryvw
approved these changes
May 5, 2019
Perryvw
reviewed
May 5, 2019
|
|
||
| test("Class decorator with parameters", () => { | ||
| const source = ` | ||
| function SetNum(this: void, numArg: number) { |
Member
There was a problem hiding this comment.
Check if decorator factories work without this: void, they should work with and without it.
Perryvw
reviewed
May 5, 2019
| } | ||
| } | ||
|
|
||
| public createConstructorDecorationStatement( |
Member
There was a problem hiding this comment.
This should probably be private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.