Conversation
tomblind
reviewed
Apr 9, 2019
Perryvw
marked this pull request as ready for review
April 13, 2019 14:31
# Conflicts: # src/LuaTransformer.ts
tomblind
reviewed
Apr 13, 2019
ark120202
reviewed
Apr 13, 2019
| "ts-jest": { | ||
| tsConfig: "<rootDir>/test/tsconfig.json", | ||
| diagnostics: { warnOnly: !isCI }, | ||
| diagnostics: { warnOnly: false }, |
Contributor
There was a problem hiding this comment.
Have you tried setting "strict": true in test/tsconfig.json instead?
ark120202
reviewed
Apr 13, 2019
| new TranspileError(`Unsupported property on ${parentName}: ${property}`, node); | ||
|
|
||
| public static UnsupportedForTarget = (functionality: string, version: string, node: ts.Node) => | ||
| public static UnsupportedForTarget = (functionality: string, version: string | undefined, node: ts.Node) => |
Contributor
There was a problem hiding this comment.
Lua undefined doesn't sound right, won't it be better to handle it in the caller? It won't complain about nullable value if it would be this.luaTarget = this.options.luaTarget || LuaTarget.LuaJIT in the LuaTransformer constructor. That also would avoid mutating passed options object.
ark120202
reviewed
Apr 13, 2019
| @@ -4547,11 +4748,12 @@ export class LuaTransformer { | |||
| throw TSTLErrors.ReferencedBeforeDeclaration(identifier); | |||
| } | |||
|
|
|||
| } else { | |||
| } else if (symbolId !== undefined) { | |||
| const sid = symbolId; // Capture non-undefined variable | |||
Contributor
There was a problem hiding this comment.
It might be simpler to replace forEach loop with a for..of instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Still need all strict issues to be solved.
Also made some preliminary interface changes to the transformer (although that should probably be finalized in a separate PR).