output cleanup - #501
Merged
Merged
Conversation
…nthesis from expressions
Perryvw
reviewed
Apr 1, 2019
tomblind
marked this pull request as ready for review
April 1, 2019 19:34
Perryvw
approved these changes
Apr 1, 2019
- using `function foo()` syntax instead of `foo = function()` - Exception made for assigned function expressions - inlining arrow functions with no body - also stripping empty do...end statements
Collaborator
Author
|
Added to this PR:
|
Perryvw
reviewed
Apr 2, 2019
Collaborator
Author
|
Last addition to this PR: tables with more than one entry are now formatted into multiple lines. |
Perryvw
reviewed
Apr 3, 2019
Collaborator
Author
|
Updated with fixes for feedback |
Perryvw
reviewed
Apr 3, 2019
…r on printReturnStatement
Perryvw
approved these changes
Apr 3, 2019
Perryvw
left a comment
Member
There was a problem hiding this comment.
Not entirely certain on adding the parentheses inside printFunctionParameters, I personally would have put them in the function header printing. I doubt it really matters though, so approved 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed wrapping all binary & unary expressions in parenthesis and fixed issues that arose. Also removed empty string literals from template strings.
I'd like to test this against some real code bases and see how fragile it is.