Skip to content

Changed position of spread operator declaration in function body #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Mar 18, 2019
Merged

Changed position of spread operator declaration in function body #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/LuaTransformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,12 @@ export class LuaTransformer {

headerStatements.push(...defaultValueDeclarations);

// Push spread operator here
if (spreadIdentifier) {
const spreadTable = this.wrapInTable(tstl.createDotsLiteral());
headerStatements.push(tstl.createVariableDeclarationStatement(spreadIdentifier, spreadTable));
}

// Add object binding patterns
let identifierIndex = 0;
const bindingPatternDeclarations: tstl.Statement[] = [];
Expand All @@ -1181,12 +1187,6 @@ export class LuaTransformer {

headerStatements.push(...bindingPatternDeclarations);

// Push spread operator here
if (spreadIdentifier) {
const spreadTable = this.wrapInTable(tstl.createDotsLiteral());
headerStatements.push(tstl.createVariableDeclarationStatement(spreadIdentifier, spreadTable));
}

const bodyStatements = this.performHoisting(this.transformStatements(body.statements));

const scope = this.popScope();
Expand Down
12 changes: 12 additions & 0 deletions test/unit/functions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,4 +511,16 @@ export class FunctionTests {
}`;
Expect(util.transpileAndExecute("return foo;", undefined, undefined, code)).toBe("foo");
}

@Test("Function rest binding pattern")
public functionRestBindingPattern(): void {
const result = util.transpileAndExecute(
`function bar(foo: string, ...[bar, baz]: [string, string]) {
return bar + baz + foo;
}
return bar("abc", "def", "xyz");
`);

Expect(result).toBe("defxyzabc");
}
}