implemented more math function and value conversions - #450
Merged
Conversation
Perryvw
reviewed
Feb 25, 2019
| case "LOG2E": | ||
| case "SQRT1_2": | ||
| case "SQRT2": | ||
| return tstl.createNumericLiteral(Math[name]); |
Member
There was a problem hiding this comment.
You should add the original TS node here
| @@ -8,7 +8,13 @@ export class MathTests { | |||
| @TestCase("Math.cos()", "math.cos();") | |||
Member
There was a problem hiding this comment.
Missing test for constants (probably would be nice to actually util.transpileAndExecute those)
Collaborator
Author
There was a problem hiding this comment.
There are tests for Math.PI and Math.E. Should I add a test for every one?
Also, I'm not sure we should do execute tests since there could be inconsistencies with precision.
Perryvw
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #438
Since I had to restructure things a bit for Math.round, I went ahead and implemented some of the other low-hanging-fruit math function conversions.