Skip to content

fixed compiler crash when unable to determine signature of function… #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomblind merged 2 commits into from
Jan 6, 2019
+17 −1
Merged

fixed compiler crash when unable to determine signature of function… #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be2ccc
fixed compiler crash when unable to determine signature of function a…
tomblind Jan 6, 2019
8e89ed8
added test
tomblind Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/TSHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,9 @@ export class TSHelper {
if (i >= 0) {
const parentSignature = checker.getResolvedSignature(signatureDeclaration.parent);
const parentSignatureDeclaration = parentSignature.getDeclaration();
declType = checker.getTypeAtLocation(parentSignatureDeclaration.parameters[i]);
if (parentSignatureDeclaration) {
declType = checker.getTypeAtLocation(parentSignatureDeclaration.parameters[i]);
}
}
} else if (ts.isReturnStatement(signatureDeclaration.parent)) {
declType = this.getContainingFunctionReturnType(signatureDeclaration.parent, checker);
Expand Down
14 changes: 14 additions & 0 deletions test/unit/assignments.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,20 @@ export class AssignmentTests {
Expect(result).toBe(expectResult);
}

@TestCase("s => s", "foo")
@TestCase("function(s) { return s; }", "foo")
@TestCase("function(this: void, s: string) { return s; }", "foo")
@Test("Valid function expression argument with no signature")
public validFunctionExpressionArgumentNoSignature(func: string, expectResult: string): void {
const code = `${AssignmentTests.funcAssignTestCode}
const takesFunc: any = (fn: (s: string) => string) => {
return (fn as any)("foo");
}
return takesFunc(${func});`;
const result = util.transpileAndExecute(code);
Expect(result).toBe(expectResult);
}

@TestCase("func", "foo+func")
@TestCase("lambda", "foo+lambda")
@TestCase("Foo.staticMethod", "foo+staticMethod")
Expand Down