Ts to lua ast assignment expressions - #317
Merged
Merged
Conversation
…ast-assignment-expressions
…ad of string literals
lolleko
approved these changes
Jan 3, 2019
|
|
||
| public transformExpressionStatement(statement: ts.ExpressionStatement): StatementVisitResult { | ||
| return tstl.createExpressionStatement(this.transformExpression(statement.expression)); | ||
| public transformExpressionStatement(expression: ts.Expression): StatementVisitResult { |
Member
There was a problem hiding this comment.
Maybe overload this so we can pass both ts.Expression and ts.ExpressionStatement
| return this.transformCompoundAssignmentExpression( | ||
| expression.operand, | ||
| ts.createLiteral(1), | ||
| expression.operator === ts.SyntaxKind.PlusPlusToken |
Member
There was a problem hiding this comment.
Ternaries inside arguments are not very readable imo. Consider changing it to:
let operator = expression.operator === ts.SyntaxKind.PlusPlusToken ? tstl.SyntaxKind.AdditionOperator : tstl.SyntaxKind.SubractionOperator;
return this.transformCompoundAssignmentExpression(
expression.operand,
ts.createLiteral(1),
operator,
true
Perryvw
approved these changes
Jan 4, 2019
…ement to take a ts.ExpressionStatement|ts.Expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignments and compound assignments all seem to be working but many of the tests still fail due to unimplemented features (template expressions, etc..).