allowing all strings to be thrown, not just literals - #244
Merged
Conversation
Perryvw
approved these changes
Oct 16, 2018
| return this.transpileTry(node as ts.TryStatement); | ||
| case ts.SyntaxKind.ThrowStatement: | ||
| return this.transpileThrow(node as ts.ThrowStatement); | ||
| return this.indent + this.transpileThrow(node as ts.ThrowStatement) + "\n"; |
Member
There was a problem hiding this comment.
Should there be a ; after this line?
Collaborator
Author
There was a problem hiding this comment.
It's not strictly necessary since error() would stop execution before anything after it tried to execute. But it might be good just for consistency.
Perryvw
approved these changes
Oct 16, 2018
lolleko
approved these changes
Oct 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables other strings, such as template strings, to be thrown. It also fixes indentation on the transpiled code.