Skip to content

Refactored Decorators - #172

Merged
lolleko merged 2 commits into
masterfrom
metaextenstion-decorator
Aug 17, 2018
Merged

Refactored Decorators#172
lolleko merged 2 commits into
masterfrom
metaextenstion-decorator

Conversation

@lolleko

@lolleko lolleko commented Aug 17, 2018

Copy link
Copy Markdown
Member
  • Added MetaExtension decorator
  • Added CustomConstructor decorator
  • Added rename functionality to !Extension
  • Tests for added decorators

Added CustomConstructor decorator
Added rename functionality to !Extension
Tests for added decorators
@lolleko
lolleko requested a review from Perryvw August 17, 2018 15:27

@Perryvw Perryvw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like DecoratorCollection, I would prefer just returning the map from getCustomDecorators instead. Other than that looks really good.

@lolleko
lolleko merged commit 60f43a4 into master Aug 17, 2018
@lolleko
lolleko deleted the metaextenstion-decorator branch August 17, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants